[SURBL-Discuss] Re: [SPAM-TAG] SURBL missing this spam

[David B Funk]

On Fri, 4 Mar 2005, Jeff Chan wrote:

> On Friday, March 4, 2005, 5:12:28 PM, Theo Dinter wrote:
> > On Fri, Mar 04, 2005 at 05:10:42PM -0800, Jeff Chan wrote:
> >> The URI is a little unusual, with a missing port number after the
> >> colon:
> >>
> >>   http://crazyrxl0wprices-MUNGED.com:/
> >>
> >> Maybe that syntax is throwing off SA?
>
> > Yeah, it does look like a bug somewhere in 3.0.x.  3.1 catches it fine,
> > fwiw.
>
> > 3.0:
> > debug: URIDNSBL: domains to query:
>
> > 3.1:
> > debug: uridnsbl: domains to query: crazyrxl0wprices.com
>
> Thanks Theo,
> Given that it's apparently fixed in 3.1 should we make a
> bugzilla?  Might it be worth reviewing that the expression or
> code was specifically fixed to explain this (better) behavior?
> Or would that be unnecessary?

For those still running SA 2.6* + SpamCopURI-0.22
The following ONE character patch fixes this bug:

*** SpamCopURI.pm-orig  Thu Aug  5 14:58:59 2004
--- SpamCopURI.pm       Fri Mar  4 21:22:37 2005
***************
*** 276,282 ****

    # URI doesn't always put the port in the right place
    # so we strip it off here
!   $url{host} =~ s/:[0-9]+$// if $url{host};


    # Cleanup for urls that come in with a dot in the front
--- 276,282 ----

    # URI doesn't always put the port in the right place
    # so we strip it off here
!   $url{host} =~ s/:[0-9]*$// if $url{host};


    # Cleanup for urls that come in with a dot in the front


(IE just change that '+' to a '*' ;)





-- 
Dave Funk                                  University of Iowa
<dbfunk (at) engineering.uiowa.edu>        College of Engineering
319/335-5751   FAX: 319/384-0549           1256 Seamans Center
Sys_admin/Postmaster/cell_admin            Iowa City, IA 52242-1527
#include <std_disclaimer.h>
Better is not better, 'standard' is better. B{